Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic action exit deltaDebt fix #674

Merged
merged 2 commits into from
May 3, 2024
Merged

Conversation

MrDeadCe11
Copy link
Member

closes #665

changed the _generateDebt and _lockCollateralAndGenerateDebt, to exit _deltaWad instead of _deltaDebt

Here is the hai basic actions for reference.

… add .nvmrc to the gitignore because I'm sure I'm the only one using that file.
@MrDeadCe11 MrDeadCe11 requested a review from pi0neerpat May 2, 2024 19:02
@MrDeadCe11 MrDeadCe11 self-assigned this May 2, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.61%. Comparing base (a2beffb) to head (81af1bb).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #674   +/-   ##
=======================================
  Coverage   90.61%   90.61%           
=======================================
  Files          58       58           
  Lines        1918     1918           
=======================================
  Hits         1738     1738           
  Misses        180      180           
Files Coverage Δ
src/contracts/proxies/actions/BasicActions.sol 96.51% <100.00%> (ø)

@MrDeadCe11 MrDeadCe11 merged commit 58b698e into dev May 3, 2024
4 of 5 checks passed
@MrDeadCe11 MrDeadCe11 deleted the fix-basic-actions-debt-precision branch May 3, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BasicActions _getGeneratedDeltaDebt precision issue
2 participants