Handle Nested Resource Validation Errors

[JVickery-TBS]

feat(dev): handle resource validation;

• Handle nested resource validation.

So we have come across this issue a couple times now, in which users come back to edit a super old dataset in which the schema has changed so much. And they try to add a new resource but some other resources fail validation. Because the resource create and update logic actions just get their own validation errors, and not other resource validation errors, this is what this PR tries to do. So if the current resource does not have any validation errors, it will go check the other ones from the ValidationError object, if it find them, it will make a new error_dict structure which is used in the Resource view functions to output the errors.

[wardi]

The parsing and reordering resource errors code is repeated 3 times and could be factored out.

We can also have errors in the dataset metadata that prevent updating resources, should that be handled as well?

[JVickery-TBS]

Reckon so, and will tighten up the reusable code

[JVickery-TBS]

@wardi okay I THINK this should be good now.

So we have a method now which goes through all of the errors in the ValidationError exception and formats them into a new dict if needed. And then the rest is done in jinja templates now which is much better. I did originally just have the new dataset_errors passing into the respective get view methods BUT then ckanext-scheming happened and I had to put a little workaround for that.

I also found out that I needed to handle the Reorder Resource javascript stuff too, so there are some additions in there to handle that.

EDIT: the Resource 1 in the screenshot is not actually the name of the resource, I just adopted how the repeating fields show errors, e.g. Repeating Field x, so I just output the index of the resource in the dataset for the error. But the open in new tab link would help the user fine there. I am seeing about the ckanext-scheming templates in our canada plugin to be able to show the resource name and field labels in the correct languages there.

[JVickery-TBS]

ckanext-scheming stuff handle in: open-data/ckanext-canada#1556

If you want me to put this one upstream, I can also add the ckanext-scheming template stuff upstream

[wardi]

This would be a great contribution upstream. Just needs some tests to cover how the errors returned from resource APIs have changed.

[JVickery-TBS]

@wardi okay all that feedback has been done now