fix: html tables rendering for subclasses of HTML5XBlock in studio preview #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow up fix to #18. Previous changes fixed rendering of the html tables in studio preview for
HTML5XBlock
. This PR changes the fix to work for subclasses ofHTML5XBlock
, likeExcludedHTML5XBlock
andCompletableHTML5XBlock
.Screenshots
HTML used for screenshots:
Before
After
Testing instructions
xblock-html
repo into<devstack-root>/src/
and change the branchxblock-html-completable
repo into<devstack-root>/src/
lms
,studio
, andlearning
MFE:xblock-html
andxblock-html-completable
intostudio
:edx@example.com
)html5
,excluded_html5
andcompletable_html5
inAdvanced Module List
html5
xblock - Advanced > Textexcluded_html5
xblock - Advanced > Exclusioncompletable_html5
xblock - Advanced > CompletablePrivate-ref
: BB-6822