Improve default settings for DnDv2 blocks #5
Conversation
numerical value" and "Margin ±" settings for items.
| "incorrect": _("No, 1 does not belong here"), | ||
| "correct": _("Yes, it's a 1") | ||
| "incorrect": INCORRECT_FEEDBACK, | ||
| "correct": CORRECT_FEEDBACK.format(zone="the top") |
There was a problem hiding this comment.
The zone= parameter should be marked for i18n, and it would be easier for translators if you used the exact same string as the name of the zone (zone=_("The Top Zone"))
|
For accessibility, we should add good examples of the zone descriptions and background descriptions to the default. Currently they are blank. Though Mark has said "I don't think it would be helpful to describe the background. The dropzone names/descriptions should describe them in the context of any given background.", so you could skip the background description if you want. |
| @@ -144,11 +144,20 @@ def items_without_answers(): | |||
| item['inputOptions'] = 'inputOptions' in item | |||
| return items | |||
|
|
|||
| def title_with_points(): | |||
| """ | |||
| Build title using `display_name` and `weight` of this Drag and Drop exercise. | |||
There was a problem hiding this comment.
What's the rationale for this change to the title? I'm not sure that course authors will like it in general - some drag and drop assignments will be ungraded, and it might confuse students to talk about how many points they can earn. In addition, authors can always just set a title like "Shapes Drag and Drop Exercise (1 point possible)", manually including the point value in the title string.
There was a problem hiding this comment.
@bradenmacdonald Good point about ungraded assignments -- this change was basically just me trying to match the screenshots in the README as closely as possible :)
I reverted the change.
4446765 to
8469ed6
Compare
|
👍 |
Improve default settings for DnDv2 blocks
... and explain "Optional numerical value" and "Margin ±" settings for items.
Cf. SOL-1451