Added metadata field for video xblocks #394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>
shimulch
approved these changes
Sep 2, 2021
There was a problem hiding this comment.
@farhaanbukhsh LGTM 👍
- I tested this: on local devstack I've tested the new metadata field appears, saving to the field persists and import-export works with this field as well.
- I read through the code
- [N/A] I checked for accessibility issues
- Includes documentation
- [N/A] I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository.
|
This is no more needed by NELP so closing this, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an additional field to video xblocks, a field called metadata, where any information related to the component can be used by admin/course-creators.
JIRA tickets: BB-4651
Discussions: Link to any public dicussions about this PR or the design/architecture. Otherwise omit this.Dependencies: NoneScreenshots:
Sandbox URL: TBD - sandbox is being provisioned.
Merge deadline: "None" if there's no rush, "ASAP" if it's critical, or provide a specific date if there is one.
Testing instructions:
make dev.restart-devserver.studioAdvancetabAuthor notes and concerns:
None
Reviewers