Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sast rescoring update #270

Merged
merged 22 commits into from
Jan 24, 2025
Merged

Sast rescoring update #270

merged 22 commits into from
Jan 24, 2025

Conversation

TuanAnh17N
Copy link
Collaborator

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

@TuanAnh17N TuanAnh17N requested a review from a team as a code owner November 27, 2024 15:55
@ocm-ci-robot-0 ocm-ci-robot-0 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 27, 2024
zkdev
zkdev requested changes Nov 28, 2024
View reviewed changes
test/test_rescoring.py Outdated Show resolved Hide resolved
test/test_rescoring.py Outdated Show resolved Hide resolved
rescore/model.py Outdated Show resolved Hide resolved
rescore/utility.py Outdated Show resolved Hide resolved
rescore/utility.py Outdated Show resolved Hide resolved
cm06/scan.py Outdated Show resolved Hide resolved
cm06/scan.py Outdated Show resolved Hide resolved
cm06/scan.py Outdated Show resolved Hide resolved
cm06/scan.py Outdated Show resolved Hide resolved
cm06/scan.py Show resolved Hide resolved
ccwienk
ccwienk requested changes Nov 29, 2024
View reviewed changes
cm06/scan.py Outdated Show resolved Hide resolved
cm06/scan.py Outdated Show resolved Hide resolved
cm06/scan.py Outdated Show resolved Hide resolved
cm06/scan.py Outdated Show resolved Hide resolved
rescore/model.py Outdated Show resolved Hide resolved
@TuanAnh17N TuanAnh17N force-pushed the sast-rescoring-update branch from 79f7529 to 5106da9 Compare December 2, 2024 16:08
@ocm-ci-robot-0 ocm-ci-robot-0 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 2, 2024
@TuanAnh17N TuanAnh17N requested review from zkdev and ccwienk December 2, 2024 16:10
8R0WNI3
8R0WNI3 requested changes Dec 3, 2024
View reviewed changes
config.py Outdated Show resolved Hide resolved
config.py Outdated Show resolved Hide resolved
config.py Outdated Show resolved Hide resolved
config.py Outdated Show resolved Hide resolved
features/__init__.py Outdated Show resolved Hide resolved
cm06/scan.py Outdated Show resolved Hide resolved
cm06/scan.py Outdated Show resolved Hide resolved
cm06/scan.py Outdated Show resolved Hide resolved
cm06/scan.py Outdated Show resolved Hide resolved
cm06/scan.py Outdated Show resolved Hide resolved
@TuanAnh17N TuanAnh17N force-pushed the sast-rescoring-update branch from 5106da9 to a3c0361 Compare December 10, 2024 19:01
@ocm-ci-robot-0 ocm-ci-robot-0 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 10, 2024
ccwienk
ccwienk requested changes Dec 11, 2024
View reviewed changes
cm06/scan.py Outdated Show resolved Hide resolved
cm06/scan.py Outdated Show resolved Hide resolved
cm06/scan.py Outdated Show resolved Hide resolved
cm06/scan.py Outdated Show resolved Hide resolved
cm06/scan.py Outdated Show resolved Hide resolved
cm06/scan.py Outdated Show resolved Hide resolved
cm06/scan.py Show resolved Hide resolved
cm06/scan.py Show resolved Hide resolved
cm06/scan.py Show resolved Hide resolved
cm06/scan.py Show resolved Hide resolved
@TuanAnh17N TuanAnh17N force-pushed the sast-rescoring-update branch from a3c0361 to 2f3b3ba Compare December 11, 2024 16:23
@ocm-ci-robot-0 ocm-ci-robot-0 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 11, 2024
@TuanAnh17N TuanAnh17N requested a review from 8R0WNI3 December 11, 2024 16:24
@ocm-ci-robot-0 ocm-ci-robot-0 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 11, 2024
zkdev
zkdev requested changes Dec 12, 2024
View reviewed changes
cm06/scan.py Outdated Show resolved Hide resolved
cm06/scan.py Outdated Show resolved Hide resolved
config.py Outdated Show resolved Hide resolved
config.py Outdated Show resolved Hide resolved
rescore/model.py Outdated Show resolved Hide resolved
rescore/model.py Outdated Show resolved Hide resolved
rescore/utility.py Show resolved Hide resolved
test/test_rescoring.py Outdated Show resolved Hide resolved
8R0WNI3
8R0WNI3 requested changes Dec 12, 2024
View reviewed changes
rescore/model.py Outdated Show resolved Hide resolved
rescore/model.py Outdated Show resolved Hide resolved
rescore/model.py Outdated Show resolved Hide resolved
rescore/model.py Outdated Show resolved Hide resolved
rescore/model.py Outdated Show resolved Hide resolved
cm06/scan.py Outdated Show resolved Hide resolved
cm06/scan.py Outdated Show resolved Hide resolved
cm06/scan.py Outdated Show resolved Hide resolved
cm06/scan.py Outdated Show resolved Hide resolved
cm06/scan.py Outdated Show resolved Hide resolved
@8R0WNI3 8R0WNI3 mentioned this pull request Dec 12, 2024
Merged
@TuanAnh17N TuanAnh17N force-pushed the sast-rescoring-update branch from 2f3b3ba to 9895c5f Compare December 16, 2024 14:54
@ocm-ci-robot-0 ocm-ci-robot-0 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 16, 2024
@TuanAnh17N TuanAnh17N requested a review from zkdev December 16, 2024 15:17
zkdev
zkdev requested changes Dec 16, 2024
View reviewed changes
cm06/scan.py Outdated Show resolved Hide resolved
rescore/utility.py Outdated Show resolved Hide resolved
rescore/utility.py Outdated Show resolved Hide resolved
@TuanAnh17N TuanAnh17N force-pushed the sast-rescoring-update branch from 9895c5f to 13f4f76 Compare December 16, 2024 16:44
@ocm-ci-robot-0 ocm-ci-robot-0 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 16, 2024
@TuanAnh17N TuanAnh17N force-pushed the sast-rescoring-update branch from f92dbbf to fa4f5e4 Compare January 23, 2025 15:13
@ocm-ci-robot-0 ocm-ci-robot-0 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 23, 2025
@TuanAnh17N TuanAnh17N force-pushed the sast-rescoring-update branch from fa4f5e4 to 0466170 Compare January 23, 2025 15:17
@ocm-ci-robot-0 ocm-ci-robot-0 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 23, 2025
@TuanAnh17N TuanAnh17N requested a review from zkdev January 23, 2025 19:58
@zkdev @TuanAnh17N
Do not track metadata twice
33d3f84 
Co-authored-by: Tuan Anh Nguyen (TuanAnh17N) <tuan-anh_nguyen@gmx.de>
@ocm-ci-robot-0 ocm-ci-robot-0 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 24, 2025
@zkdev @TuanAnh17N
refactor: Inline version filtering
b3cbc46 
Co-authored-by: Tuan Anh Nguyen (TuanAnh17N) <tuan-anh_nguyen@gmx.de>
@ocm-ci-robot-0 ocm-ci-robot-0 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 24, 2025
@zkdev @TuanAnh17N
Do not limit default-rule-set per type
de709bb 
Co-authored-by: Tuan Anh Nguyen (TuanAnh17N) <tuan-anh_nguyen@gmx.de>
@ocm-ci-robot-0 ocm-ci-robot-0 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 24, 2025
zkdev
zkdev approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@zkdev zkdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TuanAnh17N TuanAnh17N merged commit a679827 into master Jan 24, 2025
4 checks passed
@TuanAnh17N TuanAnh17N deleted the sast-rescoring-update branch January 24, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccwienk ccwienk ccwienk requested changes

@zkdev zkdev zkdev approved these changes

@8R0WNI3 8R0WNI3 Awaiting requested review from 8R0WNI3

Assignees
No one assigned
Labels
needs/ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TuanAnh17N @ccwienk @zkdev @8R0WNI3 @ocm-ci-robot-0