-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Update default version to 0.13.0 #403
🌱 Update default version to 0.13.0 #403
Conversation
Signed-off-by: Jian Qiu <jqiu@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
@@ -44,66 +44,6 @@ func GetVersionBundle(version string) (VersionBundle, error) { | |||
|
|||
// predefined bundle version | |||
// TODO: automated version tracking | |||
versionBundleList["0.5.0"] = VersionBundle{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this means we only support n-3 versions?(0.10.0, 0.11.0, 0.12.0, 0.13.0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so, we can not support earlier version since the change on operator manifests.
Operator: "v0.13.0", | ||
AddonManager: "v0.13.0", | ||
AppAddon: "v0.13.0", | ||
PolicyAddon: "v0.13.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see updated versions for any of the components (not the ones I checked). Is the 0.13.0 release in the works now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is in the progressing Operator/AddonManager have 0.13.0 already.
/lgtm |
@@ -1 +1 @@ | |||
v0.7.2 | |||
v0.8.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file necessary? can we remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's add a todo...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's referenced here for CLI versioning:
Line 9 in bb97f15
//go:embed VERSION.txt |
/unhold |
bb97f15
into
open-cluster-management-io:main
Summary
Related issue(s)
Fixes #