Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Update default version to 0.13.0 #403

Merged

Conversation

qiujian16
Copy link
Member

Summary

Related issue(s)

Fixes #

Signed-off-by: Jian Qiu <jqiu@redhat.com>
@openshift-ci openshift-ci bot requested review from itdove and yue9944882 February 29, 2024 08:04
Copy link

openshift-ci bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiujian16
Copy link
Member Author

/hold

@@ -44,66 +44,6 @@ func GetVersionBundle(version string) (VersionBundle, error) {

// predefined bundle version
// TODO: automated version tracking
versionBundleList["0.5.0"] = VersionBundle{
Copy link
Member

@zhujian7 zhujian7 Feb 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this means we only support n-3 versions?(0.10.0, 0.11.0, 0.12.0, 0.13.0)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, we can not support earlier version since the change on operator manifests.

Operator: "v0.13.0",
AddonManager: "v0.13.0",
AppAddon: "v0.13.0",
PolicyAddon: "v0.13.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see updated versions for any of the components (not the ones I checked). Is the 0.13.0 release in the works now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is in the progressing Operator/AddonManager have 0.13.0 already.

@zhujian7
Copy link
Member

zhujian7 commented Mar 7, 2024

/lgtm

@@ -1 +1 @@
v0.7.2
v0.8.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file necessary? can we remove it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add a todo...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's referenced here for CLI versioning:

//go:embed VERSION.txt

@qiujian16
Copy link
Member Author

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit bb97f15 into open-cluster-management-io:main Mar 7, 2024
8 checks passed
@qiujian16 qiujian16 deleted the version-13 branch March 8, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants