fix: adds an option to select domain before profile export #2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4ed1630 to
89600b1
Compare
|
Please find the images showing the changes addressed in this PR. |
8b53338 to
03311ca
Compare
rsdmike
requested changes
Jan 28, 2025
There was a problem hiding this comment.
Haven't dug too far into it quite yet, but first thing i see is that we shouldn't be prompting for domain export if they profile isnt ACM. Secondly, the dialog should preselect the first option -- since if they have an ACM profile, a domain MUST be selected. Lastly, if there are no domains upon trying to export an ACM profile, then the dialog should NOT come up and an error should be displayed that they must add a domain first before being able to export/use the profile.
4c7f316 to
7d505ae
Compare
d494fec to
cdceee7
Compare
cdceee7 to
a4d4929
Compare
rsdmike
approved these changes
Jan 30, 2025
RosieAMT
pushed a commit
that referenced
this pull request
Jan 30, 2025
## [3.30.1](v3.30.0...v3.30.1) (2025-01-30) ### Bug Fixes * adds an option to select domain before profile export ([#2425](#2425)) ([e80b424](e80b424))
|
🎉 This PR is included in version 3.30.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What are you changing?
Anything the reviewer should know when reviewing this PR?
If the there are associated PRs in other repositories, please link them here (i.e. open-amt-cloud-toolkit/repo#365 )