Apply CompatHelper suggestions, free NetCDF,Zarr; add & pin DiskArrays #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arlowhite
commented
Oct 9, 2024
| @@ -87,7 +87,8 @@ CpuId = "0.3" | |||
| DataFrames = "1" | |||
| DataStructures = "0.18, 0.2" | |||
| Dates = "1" | |||
| DimensionalData = "0.25, 0.26, 0.27" | |||
| DimensionalData = "0.25, 0.26, 0.27, 0.28" | |||
| DiskArrays = "=0.3.23" | |||
There was a problem hiding this comment.
this may be redundant with pin? but just to be safe
arlowhite
commented
Oct 9, 2024
| @@ -115,6 +116,7 @@ MAT = "0.10" | |||
| MLJ = "0.19.2, 0.20" | |||
| Makie = "0.20.8, 0.21" | |||
| ModelParameters = "0.4" | |||
| NetCDF = "0.11, 0.12" | |||
There was a problem hiding this comment.
0.11 needed to resolve a compatible version with DiskArrays@0.3.23
025ba07 to
563ad87
Compare
This was referenced Oct 9, 2024
This was referenced Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the suggestions from CompatHelper.
add & pin DiskArrays instead of pinning packages that depend on it. (free NetCDF, Zarr)
Note NetCDF 0.12 requires later version of DiskArrays, so we're stuck on 0.11
] updateThis results in DimensionalData updating from 0.27.9 to 0.28.2
https://github.com/rafaqz/DimensionalData.jl/releases
Note 0.28.0