This repository was archived by the owner on Oct 11, 2024. It is now read-only.
fix: feature matrix #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakita
reviewed
Sep 27, 2023
| @@ -107,6 +107,7 @@ pub fn calculate_gas_refund<SPEC: Spec>(env: &Env, gas: &Gas) -> u64 { | |||
| } | |||
|
|
|||
| #[cfg(test)] | |||
| #[cfg(not(feature = "optimism"))] | |||
There was a problem hiding this comment.
Left remove USE_GAS from handle_call_return it would not disrupt anything and would help with tests. no_gas_measuring has been shown to be just an annoyance without much benefit so it is probable that it will be removed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes tests in the call handlers for the various feature matrices.
Upstream tests were failing because the
--all-featuresflag hit both theoptimismandno_gas_measuringflags.Since
no_gas_measuringis used for the crate-levelUSE_GASconstant, as inlined below, optimism and mainnet tests were not hitting theUSE_GASpaths. Further, themainnettests were hitting theoptimismcall handler path since--all-featuresactivated the optimismcall_handler.