Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure MQTT topic and payload sections #159

Merged
merged 2 commits into from
May 31, 2022
Merged

Restructure MQTT topic and payload sections #159

merged 2 commits into from
May 31, 2022

Conversation

svefredrik
Copy link
Contributor

@svefredrik svefredrik commented Oct 12, 2021 •
edited
Loading

  • Write MQTT topic definition as ABNF rules.
  • Remove Key from topic as it is deprecated.
  • Replace '::=' with '=' in ABNF rules.
  • Update examples with new topic structure.

@svefredrik svefredrik added enhancement New feature or request Event labels Oct 12, 2021
@svefredrik svefredrik modified the milestones: 21.12, 21.06 Oct 12, 2021
@svefredrik svefredrik changed the base branch from 21.12 to 22.06 December 17, 2021 10:07
@svefredrik svefredrik modified the milestones: 21.12, 22.06 Dec 17, 2021
kieran242
kieran242 approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@kieran242 kieran242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have read carefully through all changes and feel they are logical. Approved.

@svefredrik
Restructure MQTT topic and payload sections
e7ac35f 
- Write MQTT topic definition as ABNF rules.
- For Source fields, include name as well as value in the topic to
  remove dependency on the order that they are listed. Consumer no
  longer needs to use GetEventProperties to understand what field
  each value belongs to.
- Remove Key from topic as it is deprecated.
- Replace '::=' with '=' in ABNF rules.
- Update examples with new topic structure.

Change-Id: I7ddf8ce6a37baeee1cce16e7b83be0a98831b53f
@svefredrik
Fix comments from Lisbon F2F
2859808 
- Remove SNAME from SOURCE in MQTT topic structure
- Add PublishFilter example

Change-Id: I7ade2898f8750480f5f811b3afb73883f440f116
@kieran242
Copy link
Contributor

This needs further review by members as there was a significant update since I reviewed it last on the 4th March.

Performing a get of the latest updates in this PR shows 4 conflicts within doc\Core.xml.

Please update for re-review thank you.

kieran242
kieran242 approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@kieran242 kieran242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates. Approved.

@HansBusch HansBusch merged commit 7af2cf6 into 22.06 May 31, 2022
@HansBusch HansBusch deleted the mqtt-topics branch May 31, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sujithhanwha sujithhanwha sujithhanwha approved these changes

@kieran242 kieran242 kieran242 approved these changes

Assignees
No one assigned
Labels
22.06 enhancement New feature or request Event
Projects
None yet
Milestone
22.06
Development

Successfully merging this pull request may close these issues.
4 participants
@svefredrik @kieran242 @sujithhanwha @HansBusch