-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic event data elements for Detector events #152
Conversation
Change-Id: I21039e02b20d6048c133bdf6e8073d71f51c5280
- Describe event Data section in the Message Format section. - Update Line, Field and Loitering Detector to refer to Data in the general Message Format section. Change-Id: Ieacb9f16ea49a81ab4da8e72c6fd433ff5031cf8
Change-Id: If0b70b4a21c8c593bc7c3d57a1ba26cc694ad8fc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with the ClassType but not sure whether it is wise to have one definition for ObjectID where the individual are different.
@@ -3128,12 +3128,16 @@ | |||
<varlistentry> | |||
<term>Data</term> | |||
<listitem> | |||
<para role="text">Data items are rule specific. For property events any change of the data values items must be signaled with a changed event. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Propose to leave the original sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Hans comment,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original sentence is still there. It now reads: "Data items are rule specific, except for the generic elements described here. For property events any change of the data values items must be signaled with a changed event. Non-property events may have no data items at all."
@@ -3142,7 +3146,9 @@ | |||
</tt:Source> | |||
<tt:Data> | |||
... | |||
</tt:Data> | |||
<tt:SimpleItemDescription Name="ObjectId" Type="xs:integer"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many rules already have ObjectID of type StringList. Propose to either align name or drop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick grep gives ObjectId vs ObjectID: 35 vs 5 so ObjectId wins!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with ObjectId although it is a mess.
Change-Id: I6c327765463ac41bd4ed1161dee403cba137ddce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fredrik, outlined the changes at the last Video WG Meeting and having now reviewed them again I am happy to approve.
Add section about generic event data elements for Line/Field/Loitering Detector.
Resolves #150