Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic event data elements for Detector events #152

Merged
merged 4 commits into from
Oct 25, 2021

Conversation

svefredrik
Copy link
Contributor

Add section about generic event data elements for Line/Field/Loitering Detector.

Resolves #150

Change-Id: I21039e02b20d6048c133bdf6e8073d71f51c5280
@svefredrik svefredrik added Analytics documentation Improvements or additions to documentation labels Sep 29, 2021
- Describe event Data section in the Message Format section.
- Update Line, Field and Loitering Detector to refer to Data in the
  general Message Format section.

Change-Id: Ieacb9f16ea49a81ab4da8e72c6fd433ff5031cf8
Change-Id: If0b70b4a21c8c593bc7c3d57a1ba26cc694ad8fc
Copy link
Member

@HansBusch HansBusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the ClassType but not sure whether it is wise to have one definition for ObjectID where the individual are different.

@@ -3128,12 +3128,16 @@
<varlistentry>
<term>Data</term>
<listitem>
<para role="text">Data items are rule specific. For property events any change of the data values items must be signaled with a changed event.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Propose to leave the original sentence.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Hans comment,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original sentence is still there. It now reads: "Data items are rule specific, except for the generic elements described here. For property events any change of the data values items must be signaled with a changed event. Non-property events may have no data items at all."

@@ -3142,7 +3146,9 @@
</tt:Source>
<tt:Data>
...
</tt:Data>
<tt:SimpleItemDescription Name="ObjectId" Type="xs:integer"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many rules already have ObjectID of type StringList. Propose to either align name or drop.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick grep gives ObjectId vs ObjectID: 35 vs 5 so ObjectId wins!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with ObjectId although it is a mess.

@svefredrik svefredrik added this to the 21.12 milestone Oct 12, 2021
Change-Id: I6c327765463ac41bd4ed1161dee403cba137ddce
Copy link
Contributor

@kieran242 kieran242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fredrik, outlined the changes at the last Video WG Meeting and having now reviewed them again I am happy to approve.

@HansBusch HansBusch merged commit 01dd598 into 21.12 Oct 25, 2021
@HansBusch HansBusch deleted the add-classtypes-eventdata branch October 25, 2021 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Analytics documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extensibility of event definitions
4 participants