Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaxPasswordHistoryLength #142

Merged

Conversation

davide-videotec
Copy link
Contributor

@davide-videotec davide-videotec commented Sep 7, 2021

During the plugfest we realized that there is no way to know what is the maximum password history length that can be stored in the device. So I propose to add this capability.

@HansBusch
Copy link
Member

Don't get what the capability expresses. Is it the maximum length that a password may have to be remembered, or the maximum number of passwords that can be remembered? I would assume that it is the latter. Than the next question would be does this hold per user or overall for all users?

Probably a better name would be MaxPasswordHistory and please describe in the annotation what it is about.

@davide-videotec
Copy link
Contributor Author

I have improved the description, as suggested. Yet I left the name, because I think it is similar to other capability names (MaxUserNameLength, MaxPasswordLength, ...) but at the same time it is unlikely to confuse it or misunderstand it.

@HansBusch
Copy link
Member

Thanks for the quick update. Annotation now looks good. Let's discuss the name at the virtual meeting end of the month.

@HansBusch HansBusch merged commit 7a4f594 into onvif:21.12 Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants