Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistencies in human body descriptor table #132

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Fix inconsistencies in human body descriptor table #132

merged 1 commit into from
Aug 19, 2021

Conversation

svefredrik
Copy link
Contributor

@svefredrik svefredrik commented Jul 20, 2021 •
edited
Loading

Fix inconsistencies between spec and schema for

  • Color type, fix spec, xs:string -> tt:ColorDescriptor
  • Smoking type, fix schema, bd:Smoking -> xs:string
  • UsingMobile type, fix schema, bd:UsingMobile -> xs:string
  • Activity type, fix spec, N/A -> xs:string

HansBusch
HansBusch requested changes Aug 2, 2021
View reviewed changes
Copy link
Member

@HansBusch HansBusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposal.
Agree with color and activity.
For smoking and activity I would prefer to fix the schema because the current approach isn't extensible.

@svefredrik
Copy link
Contributor Author

Could it break backwards compatibility to change schema type to string?

@svefredrik svefredrik force-pushed the analytics/humanbody-vs-schema branch from 89e1948 to 0d74330 Compare August 4, 2021 06:10
@svefredrik
Fix inconsistencies in human body spec vs schema
146a635 
Fix inconsistencies between spec table and schema for
* Color type, fix spec, xs:string -> tt:ColorDescriptor
* Smoking type, fix schema, bd:Smoking -> xs:string
* UsingMobile type, fix schema, bd:UsingMobile -> xs:string
* Activity type, fix spec, N/A -> xs:string

Change-Id: Icb18ee81f3353763f507c3340d03d1445b72b4c6
@svefredrik svefredrik force-pushed the analytics/humanbody-vs-schema branch from 0d74330 to 146a635 Compare August 4, 2021 06:12
@svefredrik
Copy link
Contributor Author

I guess it would be OK to change to xs:string so I made the change.

HansBusch
HansBusch approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member

@HansBusch HansBusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now there are no issues, since we didn't extend the enumerations up to now.

Additionally clients are typically using schema based parsers for wsdl but I don't expect that for metadata streaming.

@HansBusch HansBusch merged commit 0de4982 into 21.12 Aug 19, 2021
@HansBusch HansBusch deleted the analytics/humanbody-vs-schema branch August 19, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sujithhanwha sujithhanwha sujithhanwha approved these changes

@willysagefalk willysagefalk willysagefalk approved these changes

@HansBusch HansBusch HansBusch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@svefredrik @HansBusch @willysagefalk @sujithhanwha