Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hidden annotation with wrong restriction (related to ext-2179) #110

Merged
merged 2 commits into from
Jun 7, 2021
Merged

Remove hidden annotation with wrong restriction (related to ext-2179) #110

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1be422f
Remove hidden annotation with wrong restriction (related to ext-2179)
HansBusch May 27, 2021
2d07b9e
Fix typo related to change.
HansBusch Jun 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions wsdl/ver10/schema/onvif.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6563,12 +6563,6 @@ If set to 0.0, infinity will be used.</xs:documentation>
</xs:complexType>
<!--===============================-->
<xs:complexType name="ItemList">
<xs:annotation>
<xs:documentation>
List of parameters according to the corresponding ItemListDescription.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why we chose to remove this line?

As per our discussion, the concerning requirement was 'Each item in the list shall have a unique name.' which was to be removed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not wrong but type annotations are completely hidden. Any annotation should go into elements or attributes. See definition in tt:Config

<xs:element name="Parameters" type="tt:ItemList">
  <xs:annotation>
    <xs:documentation>List of configuration parameters as defined in the corresponding description.</xs:documentation>
  </xs:annotation>
</xs:element>

Each item in the list shall have a unique name.
</xs:documentation>
</xs:annotation>
<xs:sequence>
<xs:element name="SimpleItem" minOccurs="0" maxOccurs="unbounded">
<xs:annotation>
Expand Down Expand Up @@ -6756,7 +6750,7 @@ If set to 0.0, infinity will be used.</xs:documentation>
<xs:sequence>
<xs:element name="Parameters" type="tt:ItemList">
<xs:annotation>
<xs:documentation>List of configuration parameters as defined in the correspding description.</xs:documentation>
<xs:documentation>List of configuration parameters as defined in the corresponding description.</xs:documentation>
</xs:annotation>
</xs:element>
</xs:sequence>
Expand Down