Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: bump nrf sdk version from 2.6.2 to 2.9.1 #56

Merged
merged 19 commits into from
Mar 10, 2025

Conversation

benjaminbruun
Copy link
Collaborator

@benjaminbruun benjaminbruun commented Jul 26, 2024

With the release of the latest nRF Connect SDK v2.7.0, we will seek to follow integration guides and migrate to the latest release.

And since the nRF Connect SDK releases have jumped to v2.9.1, we will strive to support this directly through this PR.

@fellerts
Copy link

fellerts commented Nov 1, 2024

Hi, when do you expect v2.7.0 support to be implemented?

@benjaminbruun
Copy link
Collaborator Author

Hi, when do you expect v2.7.0 support to be implemented?

Should actually already be supported. Got indirectly validated as part of a previous issue.
We just haven't moved the default version to v2.7.0 yet.

@fellerts
Copy link

fellerts commented Nov 1, 2024

Thanks! I'm wondering because ncs v2.7.0 has moved to sysbuild and Nordic will deprecate child/parent images soon. The samples fail to build with --sysbuild:

CMake Error at /path/to/modules/lib/softsim/CMakeLists.txt:8 (add_custom_command):
  Error evaluating generator expression:

    $<TARGET_PROPERTY:partition_manager,PM_NVS_STORAGE_ADDRESS>

  Target "partition_manager" not found.

Is this expected to work? If not, I can create an issue.

@benjaminbruun
Copy link
Collaborator Author

Good observation, re-visiting the tests previously ran they had been build with system default build system, and not forced to sysbuild.
image

I am getting the same error as you and we will look into it. If you have any progress on the porting, feel free to push a PR or suggestion in this thread.

@fellerts
Copy link

fellerts commented Nov 6, 2024

I had a look and I got the impression that most targets in Zephyr and ncs only use partition manager generator expressions when sysbuild is not enabled. I'm not familiar enough with the Zephyr build system internals to suggest a solution unfortunately.

@benjaminbruun benjaminbruun changed the title feat: bump nrf sdk version from 2.6.1 to 2.7.0 feat: bump nrf sdk version from 2.6.2 to 2.7.0 Dec 4, 2024
@benjaminbruun benjaminbruun force-pushed the feat/start-integration-of-nrf-2.7.0 branch from a5a0365 to 7145612 Compare December 4, 2024 12:05
@benjaminbruun benjaminbruun changed the title feat: bump nrf sdk version from 2.6.2 to 2.7.0 feat!: bump nrf sdk version from 2.6.2 to 2.7.0 Jan 3, 2025
@benjaminbruun benjaminbruun changed the title feat!: bump nrf sdk version from 2.6.2 to 2.7.0 feat!: bump nrf sdk version from 2.6.2 to 2.9.0 Mar 3, 2025
@benjaminbruun
Copy link
Collaborator Author

Trying to figure out why ZEPHYR_SDK_INSTALL_DIR cannot be found when building the project within zephyrproject-rtos/ci:v0.27.4 docker-image.

@MirkoCovizzi
Copy link
Collaborator

MirkoCovizzi commented Mar 6, 2025

Trying to figure out why ZEPHYR_SDK_INSTALL_DIR cannot be found when building the project within zephyrproject-rtos/ci:v0.27.4 docker-image.

I recommend using container: ghcr.io/nrfconnect/sdk-nrf-toolchain:v2.9.0 docker image instead. The Zephyr one might miss dependencies used by NCS.

Also I suggest to move to using twister (which is included in the docker image) instead of having a custom matrix pipeline for targeting the various platforms and then manually building with west. You can see an example here https://github.com/nrfconnect/ncs-example-application/blob/main/.github/workflows/build-using-docker.yml and read more about how to use twister for this use case here https://docs.zephyrproject.org/latest/develop/test/twister.html

That would remove a lot of boilerplate from the GitHub workflow and make it much easier to maintain.

@benjaminbruun
Copy link
Collaborator Author

Trying to figure out why ZEPHYR_SDK_INSTALL_DIR cannot be found when building the project within zephyrproject-rtos/ci:v0.27.4 docker-image.

I recommend using container: ghcr.io/nrfconnect/sdk-nrf-toolchain:v2.9.0 docker image instead. The Zephyr one might miss dependencies used by NCS.

Sounds interesting and more suitable. Will give it a shot

@benjaminbruun benjaminbruun force-pushed the feat/start-integration-of-nrf-2.7.0 branch 2 times, most recently from 20a6bee to 0a65837 Compare March 6, 2025 17:33
@benjaminbruun benjaminbruun changed the title feat!: bump nrf sdk version from 2.6.2 to 2.9.0 feat!: bump nrf sdk version from 2.6.2 to 2.9.1 Mar 6, 2025
@benjaminbruun benjaminbruun marked this pull request as ready for review March 6, 2025 19:56
@benjaminbruun benjaminbruun self-assigned this Mar 7, 2025
@benjaminbruun benjaminbruun added the enhancement New feature or request label Mar 7, 2025
* Move CONFIG_SOFTSIM_BUNDLE_TEMPLATE_HEX to sysbuild.
* Fix compiler warnings when printing eDRX parameters.

Signed-off-by: Stig Bjørlykke <stig.bjorlykke@nordicsemi.no>
* Move PM_STATIC configuration to sysbuild.
* Add static partition layout for Thingy:91 X.

Signed-off-by: Stig Bjørlykke <stig.bjorlykke@nordicsemi.no>
@benjaminbruun benjaminbruun merged commit a393f70 into master Mar 10, 2025
5 checks passed
@benjaminbruun benjaminbruun deleted the feat/start-integration-of-nrf-2.7.0 branch March 10, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SoftSIM samples not compatible with Zephyr Sysbuild, the new default in nRF SDK v2.7.0
5 participants