Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hit the spacebar one time #212

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Hit the spacebar one time #212

merged 1 commit into from
Aug 9, 2024

Conversation

jeremyfowers
Copy link
Collaborator

Bug fix: process isolation mode wasn't working with Tool args because it was missing a space between the arg value and the next tool name.

This PR also:

  • Adds a Tool arg to the process isolation CI test to make sure we avoid this in the future
  • Revs the version number so we can release a hotfix

Demo

Here is a more complex example to show that things are fixed:

(tkml) PS C:\work\turnkeyml\models\transformers> turnkey -i .\electra.py --process-isolation discover --max-depth 0 --script-args="" export-pytorch --opset 17 benchmark --iterations 1 --runtime ort

Info: Running turnkey on .\electra.py

Info: Starting process with command: turnkey -i C:\work\turnkeyml\models\transformers\electra.py --cache-dir="~/.cache/turnkey"  discover --max-depth 0 --script-args= export-pytorch --opset 17 benchmark --iterations 1 --runtime ort

Info: Running turnkey on C:\work\turnkeyml\models\transformers\electra.py

Building "electra_transformers"
    + Discovering PyTorch models   
    + Exporting PyTorch to ONNX   
      Benchmarking model   
      Benchmarking model.  
      Benchmarking model.. 
      Benchmarking model...
      Benchmarking model   
      Benchmarking model.  
      Benchmarking model.. 
      Benchmarking model...
      Benchmarking model   
      Benchmarking model.  
      Benchmarking model.. 
      Benchmarking model...
      Benchmarking model   
      Benchmarking model.  
      Benchmarking model.. 
      Benchmarking model...
      Benchmarking model   
      Benchmarking model.  
      Benchmarking model.. 
      Benchmarking model...
      Benchmarking model   
      Benchmarking model.  
      Benchmarking model.. 
      Benchmarking model...
    + Benchmarking model

electra.py:
        model (executed 1x - 0.08s)
                Location:       C:\\work\\turnkeyml\\models\\transformers\\electra.py, line 24
                Parameters:     13,483,008 (51.43 MB)
                Input Shape:    'attention_mask': (1, 128), 'input_ids': (1, 128)
                Build dir:      C:\Users\jefowers/.cache/turnkey\electra_transformers
                Status:         Successful build!
                                Throughput:     128.424 inferences per second (IPS)
                                Mean Latency:   7.787 milliseconds (ms)

@jeremyfowers jeremyfowers self-assigned this Aug 9, 2024
@jeremyfowers jeremyfowers merged commit 1c69f36 into main Aug 9, 2024
6 checks passed
@jeremyfowers jeremyfowers deleted the bug/one_space_lol branch August 9, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants