Move to more recent LLVM commit ID #64
Conversation
|
|
utils/install-mlir.sh
Outdated
| # Check out a specific branch that is known to work with ONNX MLIR. | ||
| cd llvm-project && git checkout 076475713c236081a3247a53e9dbab9043c3eac2 && cd .. | ||
| mkdir llvm-project/build | ||
| if [ ! -d llvm-project ]; then |
There was a problem hiding this comment.
Any reason for introducing these conditions?
There was a problem hiding this comment.
It just made it easier to keep re-running the script so it didn't error-out if the cloned repo existed (e.g. testing out a different commit id). I can remove if required.
There was a problem hiding this comment.
That would be great. In a normal use case you shouldn't have to run this script more than once.
Since you tested several commit IDs, does this mean that the current commit ID used in your patch is not the latest?
There was a problem hiding this comment.
Yeah, it was just the latest when I looked at it last week.
Let me update to the latest commit id I can and revert back the extra conditions I added. Once I've tested I'll update this PR.
There was a problem hiding this comment.
Sounds great! Thanks a lot!
There was a problem hiding this comment.
Done! Commit id changed to latest master (as of a couple hours ago), and conditions rolled back.
There was a problem hiding this comment.
@doru1004 , how do I fix the doc errors reported from the ci?
There was a problem hiding this comment.
Never mind, got it.
|
You will also have to bump up the LLVM version in .circleci/config.yml otherwise the buildbot will use a cached version of the llvm-project instead of the new one. Currently it's V9 you should bump that up to V10 and then I think your branch will build fine. |
No problem. Since I don't have write access, can you or someone with access merge this PR into master for me? |
…o_tosa feat: add conversion of leaky relu from onnx to tosa
This change moves to a more recent LLVM commit ID and therefore allows onnx-mlir to work with latest MLIR changes.
Note that the CI build will need to be updated to the LLVM commit id specified in utils/install-mlir.sh