Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1 ---[Fix] Global emission uses malloc when returned by a function #443

Merged
merged 53 commits into from
Dec 9, 2020
Merged

#1 ---[Fix] Global emission uses malloc when returned by a function #443

merged 53 commits into from
Dec 9, 2020

Conversation

doru1004
Copy link
Collaborator

@doru1004 doru1004 commented Dec 9, 2020

This patch returns the result of a malloc when global value is returned.

doru1004 added 30 commits March 23, 2020 16:15
@doru1004
Reorganize main function.
febcc7d
@doru1004
Follow review comments.
177311e
@doru1004
Merge remote-tracking branch 'upstream/master'
a45e0f7
@doru1004
Emit constants are globals in Krnl and LLVM dialects.
f5548fb
@doru1004
Merge remote-tracking branch 'upstream/master'
fc29506
@doru1004
Merge remote-tracking branch 'upstream/master'
c1509dc
@doru1004
Merge remote-tracking branch 'upstream/master'
7d1f43d
@doru1004
Merge remote-tracking branch 'upstream/master'
639e0b1
@doru1004
Merge remote-tracking branch 'upstream/master'
b11f154
@doru1004
Merge remote-tracking branch 'upstream/master'
e3a9a43
@doru1004
Merge remote-tracking branch 'upstream/master'
2dcd97a
@doru1004
Merge remote-tracking branch 'upstream/master'
1ab3ec8
@doru1004
Merge remote-tracking branch 'upstream/master'
a3b49a7
@doru1004
Merge remote-tracking branch 'upstream/master'
e5def5c
@doru1004
Merge remote-tracking branch 'upstream/master'
c6a036c
@doru1004
Merge remote-tracking branch 'upstream/master'
d6fcb6a
@doru1004
Merge remote-tracking branch 'upstream/master'
87b3779
@doru1004
Merge remote-tracking branch 'upstream/master'
163a880
@doru1004
Merge remote-tracking branch 'upstream/master'
5ee19b0
@doru1004
Merge remote-tracking branch 'upstream/master'
2a9bf87
@doru1004
Merge remote-tracking branch 'upstream/master'
7a46709
@doru1004
Merge remote-tracking branch 'upstream/master'
c9e63a8
@doru1004
Merge remote-tracking branch 'upstream/master'
ca01afb
@doru1004
Merge remote-tracking branch 'upstream/master'
0d2eee4
@doru1004
Merge remote-tracking branch 'upstream/master'
f006465
@doru1004
Merge remote-tracking branch 'upstream/master'
b0761e8
@doru1004
Merge remote-tracking branch 'upstream/master'
b55b4cb
@doru1004
Merge remote-tracking branch 'upstream/master'
c45f310
@doru1004
Merge remote-tracking branch 'upstream/master'
bbff356
@doru1004
Merge remote-tracking branch 'upstream/master'
c2edc42
doru1004 added 16 commits August 18, 2020 17:41
@doru1004
Merge remote-tracking branch 'upstream/master'
e218ca2
@doru1004
Merge remote-tracking branch 'upstream/master'
aed4efe
@doru1004
Merge remote-tracking branch 'upstream/master'
1c10589
@doru1004
Merge remote-tracking branch 'upstream/master'
dd4f2aa
@doru1004
Merge remote-tracking branch 'upstream/master'
8ee1a43
@doru1004
Merge remote-tracking branch 'upstream/master'
022a08f
@doru1004
Merge remote-tracking branch 'upstream/master'
fd24ef0
@doru1004
Merge remote-tracking branch 'upstream/master'
8a0d847
@doru1004
Merge remote-tracking branch 'upstream/master'
9f3be93
@doru1004
Merge remote-tracking branch 'upstream/master'
07de8e4
@doru1004
Merge remote-tracking branch 'upstream/master'
e8ddcad
@doru1004
Merge remote-tracking branch 'upstream/master'
ce3dc6d
@doru1004
Merge remote-tracking branch 'upstream/master'
26d3cea
@doru1004
Merge remote-tracking branch 'upstream/master'
d333857
@doru1004
Fix global emission when value is returned.
036f1ad
@doru1004
Format.
b7a04cf
@doru1004 doru1004 changed the title Fix global emission when value is returned [Fix] Global emission uses malloc when returned by a function Dec 9, 2020
@doru1004 doru1004 mentioned this pull request Dec 9, 2020
Closed
chentong319
chentong319 approved these changes Dec 9, 2020
View reviewed changes
Copy link
Collaborator

@chentong319 chentong319 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you enable the test for SizeOp in backend (uncomment line 573 in test/backend/test.py)? This patch should make these test go through. Otherwise, the patch is good.

@doru1004
Copy link
Collaborator Author

doru1004 commented Dec 9, 2020

Can you enable the test for SizeOp in backend (uncomment line 573 in test/backend/test.py)? This patch should make these test go through. Otherwise, the patch is good.

Just enabled them.

@AlexandreEichenberger AlexandreEichenberger changed the title [Fix] Global emission uses malloc when returned by a function #1 ---[Fix] Global emission uses malloc when returned by a function Dec 9, 2020
@chentong319 chentong319 merged commit 9011ba7 into onnx:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chentong319 chentong319 chentong319 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doru1004 @chentong319