-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup of krnl iterate loops #2953
Cleanup of krnl iterate loops #2953
Conversation
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Jenkins Linux amd64 Build #15699 [push] Cleanup of krnl iterate ... started at 07:41 |
Jenkins Linux ppc64le Build #14729 [push] Cleanup of krnl iterate ... started at 08:53 |
Jenkins Linux s390x Build #15702 [push] Cleanup of krnl iterate ... started at 08:41 |
Jenkins Linux amd64 Build #15699 [push] Cleanup of krnl iterate ... passed after 1 hr 11 min |
Jenkins Linux s390x Build #15702 [push] Cleanup of krnl iterate ... passed after 1 hr 32 min |
Jenkins Linux ppc64le Build #14729 [push] Cleanup of krnl iterate ... passed after 2 hr 0 min |
The code used a mixture of constant and non-constant DialectBuilder, and that caused some strange code pattern. Now all of the lambda functions used in the Dialect Builders used constant Dialect Builder parameters.
This PR also change trivial
into the new pattern
Sometimes, blocking>1 and parallel can be true, depending on what the code was.
None of the changes here are functional.