Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of krnl iterate loops #2953

Merged

Conversation

AlexandreEichenberger
Copy link
Collaborator

@AlexandreEichenberger AlexandreEichenberger commented Sep 25, 2024

The code used a mixture of constant and non-constant DialectBuilder, and that caused some strange code pattern. Now all of the lambda functions used in the Dialect Builders used constant Dialect Builder parameters.

This PR also change trivial

loops = krnl.defineLoops(1);
krnl.iterateIE(loops, loops, {lb}, {ub}, ...);

into the new pattern

krnl.forLoopIE(lb, ub, 1, /*parallel*/ false, ...);

Sometimes, blocking>1 and parallel can be true, depending on what the code was.

None of the changes here are functional.

Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Copy link
Collaborator

@tungld tungld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlexandreEichenberger AlexandreEichenberger merged commit 40b607d into onnx:main Sep 25, 2024
7 checks passed
@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #15699 [push] Cleanup of krnl iterate ... started at 07:41

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #14729 [push] Cleanup of krnl iterate ... started at 08:53

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #15702 [push] Cleanup of krnl iterate ... started at 08:41

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #15699 [push] Cleanup of krnl iterate ... passed after 1 hr 11 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #15702 [push] Cleanup of krnl iterate ... passed after 1 hr 32 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #14729 [push] Cleanup of krnl iterate ... passed after 2 hr 0 min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants