Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for runing RunONNXModel without verify #2876

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Fix for runing RunONNXModel without verify #2876

merged 1 commit into from
Jul 13, 2024

Conversation

AlexandreEichenberger
Copy link
Collaborator

A prior PR seems to have broken the script

alexe@AChampignon roberta-base-11 % RunONNXModel.py -m roberta-base-11.onnx
Traceback (most recent call last):
  File "/Users/alexe/OM/onnx-mlir/utils/RunONNXModel.py", line 234, in <module>
    if args.verify.lower() == "onnxruntime":

this PR fixes this.

@AlexandreEichenberger
fix for runing RunONNXModel without verify
8e8b957 
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
@AlexandreEichenberger AlexandreEichenberger requested review from imaihal and removed request for imaihal July 12, 2024 16:15
hamptonm1
hamptonm1 approved these changes Jul 13, 2024
View reviewed changes
Copy link
Collaborator

@hamptonm1 hamptonm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hamptonm1 hamptonm1 merged commit a198252 into onnx:main Jul 13, 2024
7 checks passed
@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #15133 [push] fix for runing RunONNXMo... started at 13:53

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #15139 [push] fix for runing RunONNXMo... started at 14:54

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #14164 [push] fix for runing RunONNXMo... started at 15:04

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #15133 [push] fix for runing RunONNXMo... passed after 1 hr 7 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #15139 [push] fix for runing RunONNXMo... passed after 1 hr 27 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #14164 [push] fix for runing RunONNXMo... passed after 2 hr 3 min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamptonm1 hamptonm1 hamptonm1 approved these changes

@imaihal imaihal Awaiting requested review from imaihal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexandreEichenberger @jenkins-droid @hamptonm1