Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG FIX] Added is implemented flag for custom op #2872

Merged
merged 4 commits into from
Jul 12, 2024
Merged

[BUG FIX] Added is implemented flag for custom op #2872

merged 4 commits into from
Jul 12, 2024

Conversation

Abhishek-TyRnT
Copy link
Contributor

The shapehelper for Custom op gives out isImplemented as False in case there is no pattern. This PR solves this issue #2870

@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

1 similar comment
@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@Abhishek-TyRnT
Added isimplementede flag for custom op
bd3a535 
Signed-off-by: Abhishek-TyRnT <kulkarnia168@gmail.com>
@Abhishek-TyRnT
Added SameAs in inferPattern in custom mlir test case
0e624bb 
Signed-off-by: Abhishek-TyRnT <kulkarnia168@gmail.com>
@Abhishek-TyRnT Abhishek-TyRnT force-pushed the changing-isimplemented-flag-for-custom-op branch from 5adb0c3 to 0e624bb Compare July 11, 2024 14:40
@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@AlexandreEichenberger
Copy link
Collaborator

@jenkins-droid test this please

AlexandreEichenberger
AlexandreEichenberger approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@AlexandreEichenberger AlexandreEichenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it makes total sense to condition the isImplemented results on whether a pattern was provided or not.

Thanks for the fix.

@AlexandreEichenberger
Copy link
Collaborator

@Abhishek-TyRnT IPlease just confirm you are good to go, and I will merge the PR.

Thanks for your fix

AlexandreEichenberger
AlexandreEichenberger approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@AlexandreEichenberger AlexandreEichenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexandreEichenberger AlexandreEichenberger merged commit ea46b7f into onnx:main Jul 12, 2024
7 checks passed
@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #15122 [push] [BUG FIX] Added is imple... started at 22:21

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #15117 [push] [BUG FIX] Added is imple... started at 21:21

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #14147 [push] [BUG FIX] Added is imple... started at 22:32

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #15117 [push] [BUG FIX] Added is imple... failed after 24 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #15122 [push] [BUG FIX] Added is imple... passed after 1 hr 25 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #14147 [push] [BUG FIX] Added is imple... passed after 2 hr 4 min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandreEichenberger AlexandreEichenberger AlexandreEichenberger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Abhishek-TyRnT @jenkins-droid @AlexandreEichenberger