Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded NNPA infra for handling dimension specific max sizes #2871

Merged
merged 6 commits into from
Jul 11, 2024
Merged

Upgraded NNPA infra for handling dimension specific max sizes #2871

merged 6 commits into from
Jul 11, 2024

Conversation

AlexandreEichenberger
Copy link
Collaborator

Upgraded NNPA infra for handling dimension specific max sizes. Migrated some infra around to support the new framework.

@AlexandreEichenberger
added check for NNPA version and dimension specific sizes
5db9cba 
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
@AlexandreEichenberger
added new file
5092e68 
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
@AlexandreEichenberger
format
fd290e7 
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
@AlexandreEichenberger
Copy link
Collaborator Author

@tungld any reason that the NNPALimit.h is a .h as opposed to a .hpp? it seems to be only used in cpp files.

@AlexandreEichenberger
added libs include
d0d3c70 
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
tungld
tungld approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@tungld tungld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tungld
Copy link
Collaborator

tungld commented Jul 11, 2024

any reason that the NNPALimit.h is a .h as opposed to a .hpp? it seems to be only used in cpp files.

It was in a different folder that contains wrapper files for zdnn so .h. Now we can change it to .hpp. Thanks!

@AlexandreEichenberger
renamed NNPALimit to hpp suffix
bb0509b 
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
@AlexandreEichenberger
update
b0e4c34
@AlexandreEichenberger AlexandreEichenberger merged commit c5c9239 into onnx:main Jul 11, 2024
6 of 7 checks passed
@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #15113 [push] Upgraded NNPA infra for ... started at 12:46

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #15108 [push] Upgraded NNPA infra for ... started at 11:46

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #14138 [push] Upgraded NNPA infra for ... started at 12:57

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #15108 [push] Upgraded NNPA infra for ... passed after 1 hr 18 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #15113 [push] Upgraded NNPA infra for ... passed after 1 hr 48 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #14138 [push] Upgraded NNPA infra for ... passed after 2 hr 27 min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tungld tungld tungld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexandreEichenberger @tungld @jenkins-droid