Show the compilation phases #2861
Conversation
Signed-off-by: Tung D. Le <tung@jp.ibm.com>
Signed-off-by: Tung D. Le <tung@jp.ibm.com>
|
FYI @tehbone |
|
Is this default behavior or enabled via switch? |
There was a problem hiding this comment.
LGTM, thanks for acting on this quickly.
@tehbone it looks like its on, no matter what, from my read of the diff. Would you like to have a switch?
src/Compiler/CompilerUtils.cpp
Outdated
| std::string currentTime(buffer); | ||
|
|
||
| // Use blue bold text. | ||
| llvm::outs() << "[\033[34;1m" << CURRENT_COMPILE_PHASE++ << "/" |
There was a problem hiding this comment.
ANSI escape sequence isn't support on all terminal types. And different terminal might even interpret the sequence differently. So unless the color adds a lot of value, I would just leave it out.
There was a problem hiding this comment.
Ok. Removed it. Thanks!
Signed-off-by: Tung D. Le <tung@jp.ibm.com>
Signed-off-by: Tung D. Le <tung@jp.ibm.com>
Yes, it's on by default. Let me know if you want a switch or set it off. |
|
Jenkins Linux s390x Build #15079 [push] Show the compilation pha... started at 20:37 |
|
Jenkins Linux ppc64le Build #14104 [push] Show the compilation pha... started at 20:47 |
|
Jenkins Linux amd64 Build #15074 [push] Show the compilation pha... started at 19:37 |
|
Jenkins Linux amd64 Build #15074 [push] Show the compilation pha... passed after 1 hr 6 min |
|
Jenkins Linux s390x Build #15079 [push] Show the compilation pha... passed after 1 hr 33 min |
|
Jenkins Linux ppc64le Build #14104 [push] Show the compilation pha... passed after 2 hr 7 min |
This patch is to show the compilation phases which is helpful when compiling a big model that takes a long time.
This is one example of the printed information:
Starting time is added to each phase so that users know how long the current phase takes