This repository was archived by the owner on Aug 18, 2020. It is now read-only.
Add additional keys to be handled in parsing #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsl
reviewed
Apr 24, 2020
glennsl
reviewed
Apr 24, 2020
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
glennsl
reviewed
Apr 24, 2020
| @@ -29,7 +29,7 @@ let white = [' ' '\t']+ | |||
| let alpha = ['a' - 'z' 'A' - 'Z'] | |||
| let modifier = alpha+ ['-' '+'] | |||
|
|
|||
| let binding = ['a'-'z' 'A'-'Z' '0'-'9' '`' '-' '=' '[' ']' '\\' ';' '\'' ',' '.' '/'] | |||
| let binding = ['a'-'z' 'A'-'Z' '0'-'9' '`' '-' '=' '[' ']' '\\' ';' '\'' ',' '.' '/' '(' ')' '|' '_' '%' '+'] | |||
There was a problem hiding this comment.
Next question: Why is this inclusive instead of exclusive? Could it not either just exclude characters with "special" meaning, or match any single character as the last case of the production, after any cases that matches "special" characters?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.