Skip to content
This repository was archived by the owner on Apr 1, 2020. It is now read-only.

Fix #825 - Implement editor.quickOpen.caseSensitive setting #831

Merged
merged 3 commits into from
Oct 26, 2017

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented Oct 25, 2017

Issue: The 'case-sensitivity' behavior of the QuickOpen is not very clear, and it is even less clear on how you can change the behavior to get preferred functionality (more discussion on this in #825).

Fix: This changes adds a new setting - editor.quickOpen.caseSensitive that accepts either a boolean value or smart. This change makes the pre-filter step case-agnostic, and then uses this setting for running the fusejs filter step.

@bryphe
Copy link
Member Author

bryphe commented Oct 25, 2017

Fixes #825

@bryphe
Copy link
Member Author

bryphe commented Oct 25, 2017

One issue I just realized is that the filtering logic is shared between Quick Open and the Command Palette. I think the behavior is reasonable, but it might influence how we name the configuration option (maybe it makes sense to be more general than just the quickOpen menu)

@bryphe
Copy link
Member Author

bryphe commented Oct 25, 2017

I decided to change the setting to menu.caseSensitive, because this filtering logic is the same across all menus - Quick Open, Command Palette, and (soon) symbol search through language servers.

@bryphe bryphe merged commit a9fa356 into master Oct 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant