This repository was archived by the owner on Apr 1, 2020. It is now read-only.
Fix #2466 by increasing MAX_CHORD_SIZE to prevent key swallowing #2577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Pireax thanks for the PR much appreciated. We had an issue with builds on master would you be able to merge or rebase master and repush this branch? |
|
Yeah, sure thing |
Codecov Report
@@ Coverage Diff @@
## master #2577 +/- ##
======================================
Coverage 45.3% 45.3%
======================================
Files 361 361
Lines 14571 14571
Branches 1912 1912
======================================
Hits 6601 6601
Misses 7746 7746
Partials 224 224
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is in getRecentKeyPresses of the InputManager, this returns the first 4 key presses and swallows newer key presses when typing quickly. The swallowing of the keys is based on the MAX_CHORD_SIZE, setting this to 5 fixed the issue for me. To be sure I increased MAX_CHORD_SIZE to 6.