Skip to content
This repository was archived by the owner on Apr 1, 2020. It is now read-only.

Fix for #2046 Autocomplete/Suggestions don't scroll #2529

Merged
merged 1 commit into from
Aug 31, 2018

Conversation

psxpaul
Copy link
Contributor

@psxpaul psxpaul commented Aug 30, 2018

Potential fix for the issue described in #2046

@codecov
Copy link

codecov bot commented Aug 30, 2018

Codecov Report

Merging #2529 into master will increase coverage by 0.24%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2529      +/-   ##
==========================================
+ Coverage   44.51%   44.76%   +0.24%     
==========================================
  Files         351      351              
  Lines       14302    14301       -1     
  Branches     1865     1865              
==========================================
+ Hits         6367     6402      +35     
+ Misses       7709     7673      -36     
  Partials      226      226
Impacted Files Coverage Δ
...rowser/src/Editor/NeovimEditor/NeovimPopupMenu.tsx 15.38% <0%> (+2.48%) ⬆️
.../src/Services/ContextMenu/ContextMenuComponent.tsx 82.69% <100%> (+45.19%) ⬆️
browser/src/UI/components/Arrow.tsx 76.19% <0%> (+19.04%) ⬆️
browser/src/UI/components/HighlightText.tsx 100% <0%> (+23.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5beff5f...c706b6b. Read the comment docs.

@badosu
Copy link
Collaborator

badosu commented Aug 30, 2018

Fixes #1874 as well

Copy link
Member

@akinsho akinsho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good 👍 🌮

@akinsho akinsho merged commit 4bdbdc5 into onivim:master Aug 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants