This repository was archived by the owner on Apr 1, 2020. It is now read-only.
Bugfix - Regression: First run of Oni doesn't open a window #2380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a regression of #2377 - the manifestation is that, when first launching Oni, nothing happens - it takes a second launch to actually see the window.
The issue is that, we call
makeSingleInstance
, and the callback for that gets fired when any additional instance is opened, however, we weren't handling the initial case - ifisSecondInstance
is false, than we need to kick off the window launch explicitly after the 'ready' event is fired.Thanks @CrossR for catching this! 💯