Skip to content
This repository was archived by the owner on Apr 1, 2020. It is now read-only.

Allow Sidebar to be Disabled #2343

Merged
merged 4 commits into from
Jun 23, 2018
Merged

Allow Sidebar to be Disabled #2343

merged 4 commits into from
Jun 23, 2018

Conversation

CrossR
Copy link
Member

@CrossR CrossR commented Jun 21, 2018

Fixes #1562 and Fixes #2151.

@someguynamedmatt did the bulk of the work, I've just added the focus bits.

There is a few tiny bits here unrelated to the PR due to merging master onto a commit from a few months back and the pre-commit hook linting them.

someguynamedmatt and others added 4 commits February 14, 2018 23:36
# Conflicts:
#	browser/src/Input/KeyBindings.ts
#	browser/src/Services/Explorer/index.tsx
#	browser/src/Services/Sidebar/SidebarStore.ts
#	browser/src/Services/Sidebar/index.ts
Also enforce swapping to the previous split on hide.
Copy link
Member

@akinsho akinsho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@codecov
Copy link

codecov bot commented Jun 23, 2018

Codecov Report

Merging #2343 into master will decrease coverage by 0.03%.
The diff coverage is 6.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2343      +/-   ##
==========================================
- Coverage   37.55%   37.51%   -0.04%     
==========================================
  Files         299      299              
  Lines       12420    12435      +15     
  Branches     1640     1642       +2     
==========================================
+ Hits         4664     4665       +1     
- Misses       7507     7521      +14     
  Partials      249      249
Impacted Files Coverage Δ
browser/src/Services/Sidebar/index.ts 36.84% <0%> (-2.05%) ⬇️
browser/src/Input/KeyBindings.ts 2.02% <0%> (-0.05%) ⬇️
browser/src/Services/Sidebar/SidebarStore.ts 11.42% <0%> (-1.21%) ⬇️
...rowser/src/Services/WindowManager/WindowManager.ts 67.27% <66.66%> (-0.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82faff6...73da5d0. Read the comment docs.

@CrossR CrossR merged commit f8d4528 into onivim:master Jun 23, 2018
@CrossR CrossR mentioned this pull request Jun 23, 2018
akinsho pushed a commit that referenced this pull request Jul 14, 2018
#2343 added the functionality to toggle the Explorer pane in the sidebar. This adds the same functionality to the Plugins pane.

The bug mentioned in #2349 does not affect this command.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants