Feature/remove commandline timeout

[akinsho]

Following on from #2329 this PR removes the commandline menu's timeout and adds a special case to the tab color to handle commandline mode (aka same color as normal mode is used).

As I mentioned in #2329 the plan would be to add some documentation about using <silent> or <Cmd> to prevent any flickering. I think its arguably safe to say users using the commandline with mappings aka those who hit this bug are likely to be users who would be comfortable making the required changes to their mappings...

I've left off the changes re. keeping the elements vs. destroying them as at a glance this will require a much bigger/ less straightforward change than I currently can spare the time for

[codecov]

Codecov Report

Merging #2334 into master will increase coverage by 0.23%.
The diff coverage is 12%.

@@            Coverage Diff             @@
##           master    #2334      +/-   ##
==========================================
+ Coverage   37.34%   37.58%   +0.23%     
==========================================
  Files         298      299       +1     
  Lines       12352    12472     +120     
  Branches     1632     1645      +13     
==========================================
+ Hits         4613     4687      +74     
- Misses       7490     7536      +46     
  Partials      249      249

Impacted Files	Coverage Δ
browser/src/UI/components/Tabs.tsx	31.06% <0%> (-0.62%)	⬇️
browser/src/UI/components/ExternalMenus.tsx	57.14% <40%> (-1.2%)	⬇️
browser/src/UI/components/CommandLine.tsx	30.43% <6.66%> (-2.9%)	⬇️
browser/src/UI/Shell/ShellView.tsx	46.66% <0%> (-20%)	⬇️
browser/src/Services/Sidebar/index.ts	36.84% <0%> (-2.05%)	⬇️
browser/src/Services/Sidebar/SidebarStore.ts	11.42% <0%> (-1.21%)	⬇️
...ervices/Configuration/FileConfigurationProvider.ts	22.89% <0%> (-1.11%)	⬇️
...rowser/src/Services/WindowManager/WindowManager.ts	67.27% <0%> (-0.32%)	⬇️
browser/src/Services/Learning/Tutorial/Notes.tsx	52.63% <0%> (-0.15%)	⬇️
browser/src/neovim/NeovimWindowManager.ts	10.61% <0%> (-0.1%)	⬇️
... and 12 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de149d9...6f716ea. Read the comment docs.

[akinsho]

@bryphe this PR should address the performance issues raised in #2329 as well as the tab highlighting, running it locally with no issues.

Re. codecov I think it's not quite picking up salient changes as other than some styling tweaks, shuffling the same code to different and some deletions I haven't really made any changes that should drop the coverage (though it seems to..) can always remove the styling changes (they just mean the component would hide if its parent were hidden rather than be re-created every time)

[CrossR]

Just gave this a quick test!

The highlight worked fine, and the commandline worked as expected.

My custom binds needed updating to use <cmd>, which we already knew, but perhaps worth tagging this PR as "breaking-change", such that @bryphe sees it and knows to call it out in the next release.

[akinsho]

Is this alright to merge @bryphe I'm planning to add a section to the docs to explain using a <cmd> binding to avoid flickering

[bryphe]

Go for it! If both you and @CrossR are cool with it, I'm cool with it too 😄 👍

I'm planning to add a section to the docs to explain using a binding to avoid flickering

A section in the docs would be great! I'll link to it in the release notes for the next release.