Skip to content
This repository was archived by the owner on Apr 1, 2020. It is now read-only.

bugfix: Ocaml-lang-server path #1380

Merged
merged 2 commits into from
Jan 28, 2018
Merged

Conversation

akinsho
Copy link
Member

@akinsho akinsho commented Jan 27, 2018

@bryphe I've changed the path to point towards node_modules/ocaml-language-server/bin/server/index.js as by looking at the .app directory in the packaged app this was the only initialisation point I found, no executable. This works on my mac when built although I have not been able to test it works on windows (as I dont have a windows machine) but as there is no executable I use the same entry point for both windows and mac

@jordwalke
Copy link

@Akin909 Thanks for paying attention to this workflow.

@akinsho
Copy link
Member Author

akinsho commented Jan 27, 2018

@jordwalke, no worries it's been a blocker for me too for a little while 👍 hopefully this resolves that. @bryphe I've also add a small style change to the tool tip as I noticed certain popups in reason files are quite large so I've added a max width to the content (an example is hovering over ReasonReact outputs a massive chunk of text) although it includes some strange characters which I think are coming from the lsp rather than our parsing of the markdown string as I've observed this prior to the tooltip changes

@akinsho
Copy link
Member Author

akinsho commented Jan 27, 2018

Here's a screen shot of the characters I mentioned above:

screen shot 2018-01-27 at 12 00 52

@bryphe
Copy link
Member

bryphe commented Jan 28, 2018

Awesome, thanks for fixing this @Akin909 !

The characters in the quick info do look strange... Not sure where the bug is, but it seems like the ocaml-language-server is basically passing the call through to merlin: https://github.com/freebroccolo/ocaml-language-server/blob/8f69e63bd26d26505f77498c6dc2dea037527c50/src/bin/server/command/getDocumentation.ts#L12 - so it might be that merlin is sending us those.

Bringing this in now. Looking forward to trying to run our Reason test again - this might fix it 👍

@bryphe bryphe merged commit 2cf0c41 into onivim:master Jan 28, 2018
@akinsho akinsho deleted the bugfix/ocaml-lang-server branch January 28, 2018 20:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants