This repository was archived by the owner on Apr 1, 2020. It is now read-only.
Fix #1264 - 'showmatch' causing tab to lose focus #1271
Merged
+59
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kept the cursor in 'block' mode, and added a small bump like we have for motion. The tab will still show the insert mode highlight in this case. Fixes #1264 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses the 'showmatch' option. The first attempt at a fix was to just treat the 'showmatch' mode like regular insert mode, but the highlight of the matched character doesn't work correctly in that case.
Note that the change is bigger than strictly required, as I did some timeboxed refactoring to help enable better unit testing of this scenario (need to continue to refine / whittle away at
NeovimEditorand the implicit dependencies).