This repository was archived by the owner on Apr 1, 2020. It is now read-only.
Fix #1265 - Flicker / movement of neovim popup menu #1268
Merged
+13
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This was referenced Jan 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: When moving between items in the NeovimPopupMenu (or typing), there is noticeable flickering.
Defect: When the state of the neovim popup menu is changed, there is status updated in the command line. This actually causes the cursor to be positioned at the command line briefly. Because the popup menu position is based on the cursor position, this actually pulls the popup menu both vertically and horizontally, causing a noticeable flicker.
Fix: Ignore the cursor position changing when it is in the command line and we're not in command line mode.