This repository was archived by the owner on Apr 1, 2020. It is now read-only.
Feature: pass priority from config #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor status plugin to use priority from config add oni-api 0.0.17 which reflects this
|
Sweet! Really appreciate you splitting this out. Besides troubleshooting the issue, this will unblock some API changes I wanted to make, too 👍 |
|
Looks great! I'll bring this in now. Thanks @Akin909 ! |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion in #1114 this PR contains a smaller subset of proposed changes to the status bar config i.e. changes to the status item creation api. Priority and item Ids are now obtained via the users config.