This repository was archived by the owner on Apr 1, 2020. It is now read-only.
Fix #1009 - Persist background color #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8093014 to
5d177e6
Compare
|
This was definitely an improvement. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: When resizing the window, on Windows, you can see a white background. It's also visible during the initial load, before the document is ready.
Defect: For the best experience, Electron needs to know the background color before the window launches. Previously, we didn't have a way to record that.
Fix: Incorporate the
electron-settingspackage. This allows us to persist the background color as_internal.lastBackgroundColor, and use it from both the main and the renderer process.This will also open the door for persisted configuration settings..