This repository was archived by the owner on Apr 1, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bryphe, excellent work on the new Syntax highlighting (I know its still a [WIP] but looks great so far). I noticed while trying it though that it wasn't picking up
javascript.jsx
andtypescript.tsx
astsx
andjsx
filetypes (which is what I believe mostviml tsx
andjsx
plugins use or rather what they coerce the filetype to). The default config appears to be trying to account for these filetypes I think, but I noticed I wasn't getting the grammar loaded.I Tweaked the grammar loader to check if a filetype contains a dot like
javascript.jsx
in which case I split the value and return the first half so the loader can accurately use thejs
orts
textmate objects.I wasn't entirely sure if you'd want this sort of thing to be user configured(so this is a question/PR), although it took a tiny bit of digging to find out what was going on, If you rather this were user configured I could make an entry in the docs instead.
Sidenote: I've seen/used a plugin (not very popular) that set the
ft
totypescript.jsx
which wouldn't be accounted.