This repository was archived by the owner on Apr 1, 2020. It is now read-only.
Bugfix/quickopen sizing #1030
Merged
Bugfix/quickopen sizing #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is caused by a negative left position
bryphe
reviewed
Nov 28, 2017
| @@ -148,10 +148,15 @@ export class CursorPositionerView extends React.PureComponent<ICursorPositionerV | |||
| visibility: this.props.hideArrow ? "hidden" : "visible", | |||
| } | |||
|
|
|||
| const leftSidePositioning = (x: number) => Math.sign(x) !== -1 | |||
There was a problem hiding this comment.
Looks like this could be simplified with Math.abs
There was a problem hiding this comment.
Thanks for the tip @bryphe, tweaked it to use Math.abs, much simpler!
bryphe
reviewed
Nov 28, 2017
| right: this.state.isFullWidth ? "8px" : null, | ||
| maxWidth: "95%", |
There was a problem hiding this comment.
Cool, seems like this fixes the issue!
|
Change looks great @Akin909 , thank you for taking a look at this! That sizing logic is not trivial. I left some minor feedback on the PR (we might able to use |
|
Awesome, change looks good! The |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bryphe, I managed to get the flickering to stop at smaller widths, granted my solution is not the best.
I added maxWidth to the styles to prevent the fullWidth prop alternating, however I ran into an issue where the left positioning very rarely was being set to a negative value so I check its value and return it as a positive int.
Very open to any changes you might have, I did test it out locally a fair bit and it seems to work without any strange edge cases nor do I think the general functionality has changed but not sure if there's something somewhere I might have missed.
Also Added overflow scroll on the element so the user can scroll to end of that element as they can for one beneath it although I didn't do much with the scrollbar styling except make it smaller to keep it out of the way. This bit is likely not necessary and/or desirable so happy to remove it.
possibly fixes #1020