Skip to content
This repository was archived by the owner on Apr 1, 2020. It is now read-only.

Bugfix/mouse selection buffer bar #1013

Merged
merged 2 commits into from
Nov 25, 2017

Conversation

akinsho
Copy link
Member

@akinsho akinsho commented Nov 23, 2017

  • Added user-select: none to tabs.less to stop users highlighting buffer bar text.
  • Added keys to WindowSplits - 😟 I couldn't find any id like data to use as keys hopefully the index here will be fine if not ill take them out, was just desperate to make the error go away
  • Fixes Make buffer tab text not selectable by the OS: #1010 (hopefully)

  - using user-select: none
* added keys to WindowSplits (as the react keys error is Super distracting for me 😟)
@bryphe
Copy link
Member

bryphe commented Nov 24, 2017

Awesome, thanks for fixing this @Akin909 !

PR looks good, I'm re-running the OSX build but I don't believe the failure is related to the change.

Added keys to WindowSplits - 😟 I couldn't find any id like data to use as keys hopefully the index here will be fine if not ill take them out, was just desperate to make the error go away

Cool, I think is reasonable for now, and it will definitely reduce noise - at the moment we only have one split. We'll need to add a proper ID later (once that is actually leveraged).

@bryphe
Copy link
Member

bryphe commented Nov 25, 2017

I tested locally and ran it, and it passed - I believe this may be failing due to the typescript version being upgraded (it's using 2.6.1 on the build machine), but the change doesn't have the #1003 fixes in it. I'll bring it and check the master build.

Thanks @Akin909 !

@bryphe bryphe merged commit 759aa62 into onivim:master Nov 25, 2017
@akinsho akinsho deleted the bugfix/mouse-selection-buffer-bar branch November 25, 2017 08:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants