The App doesn't quit with [command+Q] on macOS

[a-eid]

Most if not all macOS applications terminate with [Command + Q].

[dasosjt]

Could be configured by a little config file with other bindings/shortcuts

…

On Nov 12, 2017 11:25 PM, "Ahmed Eid" ***@***.***> wrote: Most if not all macOS applications terminate with [Command + Q]. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#928>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMm5x19DcJcqmOSPxnAKsGV3qvi0S5IUks5s19K2gaJpZM4QbQl3> .

[ghost]

Strange. I'm on macOS with version 0.2.16 and it does quit on cmd+Q when I try it.

[bryphe]

Thanks for the report, @a-eid !

Strange, this should have been addressed by PR #787 (there is actually configuration for it here:

oni/browser/src/Input/KeyBindings.ts

Line 22 in 01f4397

input.bind("<m-q>", "oni.quit")

)

I wonder if there is a certain case where the input bindings aren't getting captured? That could potentially be a more general issue impacting other scenarios..

@a-eid @dasosjt - does this reproduce consistently for you?

In addition, did you use the latest release binary (0.2.16), or build from source?

[bryphe]

I'll close this out since I'm unable to reproduce. Feel free to re-open or log a new issue if you're still seeing this!

[benjamin-rood]

Hi @bryphe I can reproduce this bug, but only under a distinct condition: If one closes the Oni window, with :q for example, then command+Q will no longer work. (Otherwise ⌘+Q is working correctly.)

Logically, if the only Oni Window/tab is closed, then this should result in also quitting the app.

Sidenote: I think q should behave the same as bd, closing the currently open tab, rather than closing all the tabs. i.e. behave the same as closing a split inside NeoVim?