-
Notifications
You must be signed in to change notification settings - Fork 33
Conversation
|
Hey @NtTestAlert , thanks for the PR! I will review this & try to release it today :) |
Hi, there is one more thing to be done, stable-cadence cli adds |
Added execName param to emulator, defaulting to flow-c1 With additional changes (support for old transactions/scripts) might allow users to mix emulator versions, in order to test migration. But that is out of the scope of this PR |
I tried getting CI to work, but I'm having issues so I guess I can just run locally to verify for now (I force pushed to roll back some of my failed attempts to fix it) I just ran the tests and it looks good, but it seems like signer parsing fails for an entitled account reference as a signer (e.g. Are we able to support this? Seems like it might be a blocker for any real usage of the library? |
The tests for flow-js-testing pass, incl those with authorized signers - it doesn't try to parse them before executing AFAIK Pipeline failed because it could not parse version due to the upgrade banner, bypassed by adding --output json to "fool" flow-cli |
Still need to adapt the library to work with shorthand imports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!! I've brought this up to date with the latest @onflow/flow-cadut@stable-cadence
release & will merge this, release -> @onflow/flow-js-testing@stable-cadence
. Thank you for your contribution!
Closes #224
Description
Various changes to support Cadence 1.0 emulator
All tests are passing
I've changed the workflow to use Cadence 1.0 CLI
This will need to be reverted later on
For contributor use:
master
branchFiles changed
in the Github PR explorer