This repository has been archived by the owner on Nov 5, 2024. It is now read-only.
Fix default compute limit deprecation warning #177
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the warning about the deprecated default compute limit for transactions.
Previously, providing a compute limit for transactions was optional, and a fallback existed (DEFAULT_COMPUTE_LIMIT=10). Compute limits may still be applied explicitly in a transaction.
flow-js-testing
already has a way to set the limit per transaction, but the default value is also required now.The value is set to 999 as it was in interactions, and the value is now imported to interactions from the config file just to have it in one location.
Also, a configuration test is added.
More information about the deprecation https://github.com/onflow/fcl-js/blob/master/packages/sdk/TRANSITIONS.md#0009-deprecate-default-compute-limit
For contributor use:
master
branchFiles changed
in the Github PR explorer