Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Fix default compute limit deprecation warning #177

Merged
merged 2 commits into from
Oct 24, 2022

Conversation

adbario
Copy link
Contributor

@adbario adbario commented Aug 27, 2022

Description

Fixes the warning about the deprecated default compute limit for transactions.

FCL/SDK Deprecation Notice
==========================
    
The built-in default compute limit (DEFAULT_COMPUTE_LIMIT=10) is
deprecated and will cease to work in future releases of FCL/SDK.

Previously, providing a compute limit for transactions was optional, and a fallback existed (DEFAULT_COMPUTE_LIMIT=10). Compute limits may still be applied explicitly in a transaction.

flow-js-testing already has a way to set the limit per transaction, but the default value is also required now.

The value is set to 999 as it was in interactions, and the value is now imported to interactions from the config file just to have it in one location.

Also, a configuration test is added.

More information about the deprecation https://github.com/onflow/fcl-js/blob/master/packages/sdk/TRANSITIONS.md#0009-deprecate-default-compute-limit


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation – No relevant parts in documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels – No permissions to add labels

@adbario adbario requested a review from a team as a code owner August 27, 2022 18:52
@changeset-bot
Copy link

changeset-bot bot commented Aug 27, 2022

🦋 Changeset detected

Latest commit: dd4ecba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@onflow/flow-js-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@justinbarry
Copy link
Contributor

@adbario Can you add a changeset file to this PR and I can merge it down. Thank you very much!

@justinbarry
Copy link
Contributor

Here are the instructions:

Thank you for your contribution! Would you be able to add a
changeset file for this? Just run npm run changeset at the root and follow the prompts using these conventions:

  • MAJOR version when you make incompatible API changes,
  • MINOR version when you add functionality in a backwards compatible manner, and
  • PATCH version when you make backwards compatible bug fixes.

@adbario
Copy link
Contributor Author

adbario commented Sep 19, 2022

@adbario Can you add a changeset file to this PR and I can merge it down. Thank you very much!

Thanks @justinbarry 🚀

Changeset added, sorry I missed that before.

@gregsantos gregsantos merged commit 8d75426 into onflow:master Oct 24, 2022
This was referenced Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants