Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Add signUserMessage & verifyUserSignatures utilites #166

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Add signUserMessage & verifyUserSignatures utilites #166

merged 1 commit into from
Aug 26, 2022

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Aug 10, 2022 •
edited
Loading

Closes #96

Description

  • Add signUserMessage utility
  • Add verifyUserSignatures utility

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@jribbink jribbink requested a review from a team as a code owner August 10, 2022 00:39
@changeset-bot
Copy link

changeset-bot bot commented Aug 10, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 39b107c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@onflow/flow-js-testing Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jribbink jribbink marked this pull request as draft August 10, 2022 00:39
@jribbink jribbink added the enhancement New feature or request label Aug 11, 2022
@jribbink jribbink force-pushed the jribbink/sign-user-message branch 3 times, most recently from 38efa28 to 114b0e6 Compare August 12, 2022 20:13
@jribbink jribbink marked this pull request as ready for review August 12, 2022 20:13
@jribbink jribbink requested a review from chasefleming August 12, 2022 20:13
justinbarry
justinbarry approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@justinbarry justinbarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jribbink jribbink force-pushed the jribbink/sign-user-message branch 2 times, most recently from 5ce6c2e to fc1f850 Compare August 26, 2022 21:19
@jribbink jribbink force-pushed the jribbink/sign-user-message branch from fc1f850 to 39b107c Compare August 26, 2022 21:52
@jribbink jribbink merged commit 69b25e0 into master Aug 26, 2022
@jribbink jribbink deleted the jribbink/sign-user-message branch August 26, 2022 21:56
@github-actions github-actions bot mentioned this pull request Aug 26, 2022
Merged
This was referenced Mar 16, 2023
Merged
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@justinbarry justinbarry justinbarry approved these changes

@chasefleming chasefleming Awaiting requested review from chasefleming

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement "signUserMessage" to sign arbitrary messages with accounts created with "getAccountAddress"
2 participants
@jribbink @justinbarry