Validate consistency of chunk Start and End states #6871
Conversation
Receipt validator checks that `chunk[i].EndState == chunk[i+1].StartState`
Modify ChunkListFixture to have consistent chunk start and end states. Previously, chunk start and end states were assigned independently, resulting in invalid execution receipts being used in tests.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6871 +/- ##
=======================================
Coverage 41.11% 41.11%
=======================================
Files 2116 2116
Lines 185737 185742 +5
=======================================
+ Hits 76368 76373 +5
+ Misses 102952 102951 -1
- Partials 6417 6418 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
|
||
| // We have at least one chunk, check chunk state consistency | ||
| chunks := result.Chunks.Items() | ||
| for i := range chunks[:len(chunks)-1] { |
There was a problem hiding this comment.
| for i := range chunks[:len(chunks)-1] { | |
| for i := range len(chunks) - 1 { |
As of Go 1.22, you can range over a number directly.
There was a problem hiding this comment.
Hm, I recall trying this (range over a number) in a previous PR but it failed the linter. At the time I thought it was because I was using Go 1.23 locally and the linter was running on Go 1.22, and the language feature was only supported in Go 1.23; but if it was added in 1.22 maybe it's just the linter that's behind?
There was a problem hiding this comment.
in this commit: link the linter complained about "cannot range over untyped int constant" - maybe it was the fact that it wasn't explicitly typed, rather than the syntax itself?
There was a problem hiding this comment.
Interesting. Did a bit of digging and it seems like:
- the linter is compatible with Go versions up to the version it was compiled with
- older releases are not re-compiled with new Go versions
The linter version we use v1.54.2 was compiled with go1.21, hence the lack of compatibility. We will need to update the linter version.
% ./golangci-lint version
golangci-lint has version 1.54.2 built with go1.21.0 from 411e0bbb on 2023-08-21T12:04:32Z
Co-authored-by: Jordan Schalm <jordan.schalm@flowfoundation.org>
Co-authored-by: Jordan Schalm <jordan.schalm@flowfoundation.org>
Ensure the receipt validator (consensus node) verifies that each chunk's end state is the same as the next chunk's start state. This PR also adds a test with an inconsistent chunklist that should trigger this error, as well as updates tests to have consistent chunklists by default (previously, the chunklists generated for tests were inconsistent.)
The requirement that the first chunk's starting state matches the end state from the previous execution result is already checked in
resultChainCheck.Issue: https://github.com/onflow/flow-go-internal/issues/5491