[Chunk Data Pack Pruner] Add Block Iterator #6858
Conversation
| } | ||
|
|
||
| // BlockIterator is an interface for iterating over blocks | ||
| type BlockIterator interface { |
There was a problem hiding this comment.
The BlockIterator interface can be implemented into height based iterator and view based iterator.
The block iterator not long can be used by chunk data pack pruner, but alsoin future to implement protocol state pruner.
The height based iterator is easy to implement, however, it can't guarantee to prune all data, since it doesn't iterate unfinalized blocks. The view based iterator can guarantee all blocks are pruned, but it's more complicated to implement.
In this PR, I first implement the height based iterator, for chunk data pack, it's OK that we only prune by height, however, for protocol state, it's better that we can prune by view and ensure a more throughout pruning.
| jobCreator IteratorJobCreator | ||
| } | ||
|
|
||
| func NewIteratorFactory( |
There was a problem hiding this comment.
Once the interfaces in the arguments are implemented, then the logic to create the BlockIterator can be reused. That's why, I put this function here along with the interface definitions, so that it's clear to see how the interfaces will be used for creating the block iterator.
77fb95b to
5b15c09
Compare
b688ac2 to
0af09d6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6858 +/- ##
=======================================
Coverage 41.11% 41.12%
=======================================
Files 2116 2118 +2
Lines 185749 185800 +51
=======================================
+ Hits 76378 76411 +33
- Misses 102954 102975 +21
+ Partials 6417 6414 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR adds a height based block iterator that iterates blocks by height, without iterating siblings of finalized blocks, which will be done later by implementing view based block iterator.