Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherrypick commits from PR: https://github.com/onflow/flow-go/pull/6513 #6530

Merged
merged 2 commits into from
Oct 3, 2024
Merged

cherrypick commits from PR: https://github.com/onflow/flow-go/pull/6513 #6530

merged 2 commits into from
Oct 3, 2024

Conversation

vishalchangrani
Copy link
Contributor

@vishalchangrani vishalchangrani commented Oct 3, 2024 •
edited by turbolent
Loading

@vishalchangrani vishalchangrani self-assigned this Oct 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 41.66%. Comparing base (c0377f2) to head (654b0cb).

Files with missing lines Patch % Lines
fvm/environment/program_recovery.go 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##            v0.37    #6530      +/-   ##
==========================================
+ Coverage   41.27%   41.66%   +0.38%     
==========================================
  Files        2020     2004      -16     
  Lines      144929   143219    -1710     
==========================================
- Hits        59817    59668     -149     
+ Misses      78885    77333    -1552     
+ Partials     6227     6218       -9
Flag Coverage Δ
unittests 41.66% <0.00%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent turbolent requested a review from a team October 3, 2024 22:21
@vishalchangrani vishalchangrani merged commit fd23598 into v0.37 Oct 3, 2024
54 of 55 checks passed
@vishalchangrani vishalchangrani deleted the vishal/v0_37_merge_pr_6513 branch October 3, 2024 22:59
@vishalchangrani vishalchangrani restored the vishal/v0_37_merge_pr_6513 branch October 3, 2024 22:59
@vishalchangrani vishalchangrani deleted the vishal/v0_37_merge_pr_6513 branch October 3, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramtinms ramtinms ramtinms approved these changes

@zhangchiqing zhangchiqing zhangchiqing approved these changes

@turbolent turbolent turbolent approved these changes

@joshuahannan joshuahannan Awaiting requested review from joshuahannan

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik janezpodhostnik is a code owner

Assignees

@vishalchangrani vishalchangrani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vishalchangrani @codecov-commenter @turbolent @zhangchiqing @ramtinms @joshuahannan