Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.37] Reject entitled Account.capabilities.get/borrow/publish #6500

Merged
merged 11 commits into from
Sep 27, 2024

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Sep 25, 2024

@turbolent turbolent requested review from j1010001 and a team September 25, 2024 21:52
@turbolent turbolent self-assigned this Sep 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 13.63636% with 38 lines in your changes missing coverage. Please review.

Project coverage is 41.27%. Comparing base (918f95a) to head (55352fb).

Files with missing lines Patch % Lines
fvm/environment/mock/environment.go 0.00% 34 Missing ⚠️
fvm/environment/facade_env.go 60.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            v0.37    #6500      +/-   ##
==========================================
- Coverage   41.42%   41.27%   -0.15%     
==========================================
  Files        2020     2020              
  Lines      144877   144921      +44     
==========================================
- Hits        60010    59819     -191     
- Misses      78637    78879     +242     
+ Partials     6230     6223       -7     
Flag Coverage Δ
unittests 41.27% <13.63%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent turbolent changed the title Reject entitled Account.capabilities.get/borrow/publish [v0.37] Reject entitled Account.capabilities.get/borrow/publish Sep 25, 2024
@turbolent
Copy link
Member Author

I guess we need to downgrade the SDK again?

@turbolent turbolent force-pushed the bastian/port-internal-6967 branch from 797caf1 to c1441d5 Compare September 27, 2024 16:59
@turbolent turbolent merged commit bb12f14 into v0.37 Sep 27, 2024
55 checks passed
@turbolent turbolent deleted the bastian/port-internal-6967 branch September 27, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants