-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v0.37] Reject entitled Account.capabilities.get/borrow/publish #6500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbolent
requested review from
ramtinms and
janezpodhostnik
as code owners
September 25, 2024 21:52
SupunS
approved these changes
Sep 25, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v0.37 #6500 +/- ##
==========================================
- Coverage 41.42% 41.27% -0.15%
==========================================
Files 2020 2020
Lines 144877 144921 +44
==========================================
- Hits 60010 59819 -191
- Misses 78637 78879 +242
+ Partials 6230 6223 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
turbolent
changed the title
Reject entitled Account.capabilities.get/borrow/publish
[v0.37] Reject entitled Account.capabilities.get/borrow/publish
Sep 25, 2024
j1010001
approved these changes
Sep 26, 2024
ramtinms
approved these changes
Sep 27, 2024
I guess we need to downgrade the SDK again? |
turbolent
force-pushed
the
bastian/port-internal-6967
branch
from
September 27, 2024 16:59
797caf1
to
c1441d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of internal https://github.com/dapperlabs/flow-go/pull/6967