Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FVM] Fix metering invalidation - port #6461

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

janezpodhostnik
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 8 lines in your changes missing coverage. Please review.

Project coverage is 41.51%. Comparing base (d100ebe) to head (ec1e02b).

Files with missing lines Patch % Lines
fvm/transactionInvoker.go 57.14% 2 Missing and 1 partial ⚠️
fvm/environment/value_store.go 66.66% 1 Missing and 1 partial ⚠️
fvm/storage/derived/table.go 75.00% 2 Missing ⚠️
fvm/storage/derived/derived_block_data.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            v0.37    #6461      +/-   ##
==========================================
- Coverage   41.51%   41.51%   -0.01%     
==========================================
  Files        2017     2017              
  Lines      143993   144007      +14     
==========================================
+ Hits        59785    59789       +4     
- Misses      78009    78015       +6     
- Partials     6199     6203       +4     
Flag Coverage Δ
unittests 41.51% <78.94%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janezpodhostnik janezpodhostnik merged commit 5be1172 into v0.37 Sep 12, 2024
55 checks passed
@janezpodhostnik janezpodhostnik deleted the janez/fix-metering-invalidation-port branch September 12, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants