try to update to new middleware #5740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterargue
approved these changes
Apr 19, 2024
kc1116
approved these changes
Apr 19, 2024
Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
|
fixed linter and applies suggestions. PTAL. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5740 +/- ##
==========================================
+ Coverage 56.00% 63.71% +7.70%
==========================================
Files 1024 103 -921
Lines 99327 11665 -87662
==========================================
- Hits 55632 7432 -48200
+ Misses 39455 3495 -35960
+ Partials 4240 738 -3502
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the grpc middleware to v2.1.0 and use the new code for the logging interceptor.
note that the
was removed in the stable api because "it was not beeing used", if this is used here and we want to do this we have to put the fields into context and then inject them in.
Fixes #5739