[Access] Added transaction result in SendAndSubscribeTransactionStatuses response #5620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isarchuk/5566-tx-result-in-sub-tx-statuses
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5620 +/- ##
==========================================
- Coverage 56.00% 48.70% -7.31%
==========================================
Files 1024 9 -1015
Lines 99327 501 -98826
==========================================
- Hits 55632 244 -55388
+ Misses 39455 251 -39204
+ Partials 4240 6 -4234
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…isarchuk/5566-tx-result-in-sub-tx-statuses
…isarchuk/5566-tx-result-in-sub-tx-statuses
peterargue
reviewed
Apr 8, 2024
peterargue
approved these changes
Apr 10, 2024
durkmurder
reviewed
Apr 15, 2024
durkmurder
reviewed
Apr 15, 2024
durkmurder
reviewed
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5566
Includes changes for response of
SendAndSubscribeTransactionStatuses, which have transaction status in it from now on.Another change related to reporting all transaction statuses one by one, even if they were skipped by blockchain behaviour.
IMPORTANT CHANGES TO MERGE:
Related PR from flow protobuf project: onflow/flow#1448
Related PR from flow-emulator project: onflow/flow-emulator#630